refactor: Simplify quinn rpc test #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace with the new tools in quic-rpc v0.17.3
also fix warning regarding urkls in readme to test: RUSTDOCFLAGS="--cfg iroh_docsrs" cargo +nightly doc --all-features --no-deps --open
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/39/docs/iroh_blobs/ Last updated: 2024-12-12T17:05:36Z |
dignifiedquire
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify quinn rpc test using the new features of quic-rpc v0.17.3
Also get rid of the bincode dependency and use doc_auto_config
Breaking Changes
None
Notes & open questions
Change checklist